Difference between revisions of "User:Hendy:Flashblock"

From Camino Wiki
Jump to navigation Jump to search
(→‎IDNs: visually they are different)
Line 3: Line 3:
 
==IDNs==
 
==IDNs==
  
Both our Flashblock system and permissions accept and work with IDNs.
+
Both our Flashblock system and permissions accept and work with IDNs (permissions automatically punycodes all IDNs, while Flashblock is comfortable with UTF-8 representations).
  
 
==Non-standard ports==
 
==Non-standard ports==

Revision as of 21:18, 26 March 2010

Flash exceptions list does not accept input of full URLs ("Add" button stays greyed out)

IDNs

Both our Flashblock system and permissions accept and work with IDNs (permissions automatically punycodes all IDNs, while Flashblock is comfortable with UTF-8 representations).

Non-standard ports

Flashblock works with non-standard ports

 www.hutech.edu.vn:8080 will allow flash on www.hutech.edu.vn:8080
 but www.hutech.edu.vn will block flash on www.hutech.edu.vn:8080

Permissions will take non-standard ports, but doesn't store them

 www.hutech.edu.vn:8080 will be stored as www.hutech.edu.vn
 Presumably, permissions will only consider the host when deciding
 whether to allow something.


Strategy

Validation for both should be the same, and minimal

 Done in WebFeatures isPartialStringValid
   Strip scheme and anything after the first slash (ie: the path)
   Don't allow /
   Length > 0
   Must have host and tld
   If flashblock, isn't already in whitelist

Committing to popup whitelist

 Send it straight to permissions

Committing to flashblock

 Send straight to flashblock