Difference between revisions of "Talk:Development:Reviewing"
Jump to navigation
Jump to search
(discussion) |
(→Thoughts on review model: oops) |
||
| Line 1: | Line 1: | ||
==Thoughts on review model== | ==Thoughts on review model== | ||
| − | [6:49pm] ss|work2: Everyone should be targeting the "newbie" reviewers first and letting the sr and/or smorgan look at it after that. | + | [6:49pm] ss|work2: Everyone should be targeting the "newbie" reviewers first and letting the sr and/or smorgan look at it after that.<br> |
| − | [6:49pm] ardissone: i agree | + | [6:49pm] ardissone: i agree<br> |
| − | [6:50pm] ss|work2: If it's small code, let a newbie reviewer look at it, then an sr. | + | [6:50pm] ss|work2: If it's small code, let a newbie reviewer look at it, then an sr.<br> |
| − | [6:50pm] ss|work2: If it's big code, newbie reviewer than smorgan, who might find more. | + | [6:50pm] ss|work2: If it's big code, newbie reviewer than smorgan, who might find more.<br> |
| − | [6:50pm] ardissone: or complex | + | [6:50pm] ardissone: or complex<br> |
| − | [6:50pm] ss|work2: That will help the newbie reviewer see what they missed as well without burdening the sr queue | + | [6:50pm] ss|work2: That will help the newbie reviewer see what they missed as well without burdening the sr queue<br> |
| − | [6:50pm] ss|work2: Right. | + | [6:50pm] ss|work2: Right.<br> |
| − | [6:50pm] ss|work2: s/big/complex | + | [6:50pm] ss|work2: s/big/complex<br> |
| − | [6:50pm] ardissone: small code can still have complex interactions | + | [6:50pm] ardissone: small code can still have complex interactions<br> |
Revision as of 14:57, 19 May 2006
Thoughts on review model
[6:49pm] ss|work2: Everyone should be targeting the "newbie" reviewers first and letting the sr and/or smorgan look at it after that.
[6:49pm] ardissone: i agree
[6:50pm] ss|work2: If it's small code, let a newbie reviewer look at it, then an sr.
[6:50pm] ss|work2: If it's big code, newbie reviewer than smorgan, who might find more.
[6:50pm] ardissone: or complex
[6:50pm] ss|work2: That will help the newbie reviewer see what they missed as well without burdening the sr queue
[6:50pm] ss|work2: Right.
[6:50pm] ss|work2: s/big/complex
[6:50pm] ardissone: small code can still have complex interactions
