Difference between revisions of "Development:Planning:Toolbar item validation"
| Line 5: | Line 5: | ||
==Go Back== | ==Go Back== | ||
Must have at least one non-about:blank page previous to the current page in the current tab/window's session history to be enabled | Must have at least one non-about:blank page previous to the current page in the current tab/window's session history to be enabled | ||
| − | : | + | :We already do this. |
==Go Forward== | ==Go Forward== | ||
Must have at least one non-about:blank page subsequent to the current page in the current tab/window's session history to be enabled | Must have at least one non-about:blank page subsequent to the current page in the current tab/window's session history to be enabled | ||
| − | : | + | :We don't already do this. |
==Reload Page== | ==Reload Page== | ||
| Line 26: | Line 26: | ||
==Manage Bookmarks== | ==Manage Bookmarks== | ||
| − | + | *Disable only when manager is open and the page "behind" the manager is about:blank, including situations where a new window/tab is opened with about:bookmarks. ('''we already do this''') | |
| + | *Change icon state when the manager is open ({{bug|235863}} | ||
==Progress== | ==Progress== | ||
Revision as of 23:10, 25 June 2006
This is an ongoing attempt at auditing the validation state of all our toolbar items. A similar page exists for menu item validation (cross-reference relevant discussion in Internal URIs also).
Any toolbar items that don't specify validation parameters are always enabled.
Contents
Go Back
Must have at least one non-about:blank page previous to the current page in the current tab/window's session history to be enabled
- We already do this.
Go Forward
Must have at least one non-about:blank page subsequent to the current page in the current tab/window's session history to be enabled
- We don't already do this.
Reload Page
Disable when a page is in the "Looking up" stage (Bug 341895). Disable when about:blank, about:bookmarks, or about:history are showing.
Stop Loading
Disable when a page and all its associated elements have finished loading
- what about post-initial-load ajax stuff?
Go Home
Disable when the current tab/window is displaying the home page
- what about multiple home pages? when any one of the pages is in view? is there discussion in the bug?
Location/Search
Manage Bookmarks
- Disable only when manager is open and the page "behind" the manager is about:blank, including situations where a new window/tab is opened with about:bookmarks. (we already do this)
- Change icon state when the manager is open (Bug 235863
Progress
- Active (spinning) the same as "Stop Loading" above
- Is a button for the Camino home page, so always enabled
- Has no "inactive state" image (compare to Cocoa throbber)
- Should really be a Cocoa throbber
Disable when viewing about:blank, about:config, about:history, about:bookmarks
View Page Source
See discussion in Development:Planning:Internal URIs
Bookmark Page
See discussion in Development:Planning:Menu item validation
New Tab
Close Tab
Disable when no tabs are present in the window, or when one tab is present but the tab bar is always shown
Bigger Text & Smaller Text
Disable both for about:blank, about:config, about:history, about:bookmarks, and tabs/windows of solely binary content
Email Page Location
Disable for all about: URIs and all view-source: URIs
Customize
Disable when currently customizing the toolbar (we already do this)
Downloads
It either opens the Downloads window or focuses it if open (we already do this)
Fill Form
Disable on all about: URIs, all view-source: URIs, all URIs of solely binary content, and, if possible, any page without form fields
History
Disable only when the History view of the Bookmarks Manager is active
Still need to cross-reference all of these with the discussions on the other two pages.
