Development:Reviewing

Camino's reviewing is a bit different than that of the Mozilla project. This document outlines how reviewing works in Camino and who to ask for reviews.

How Many Reviews?

Typically, Camino requires three reviews for checkin: two normal reviews and on super-review. This rule can be overridden by any of the super-reviewers. The reason Camino requires two normal reviews is for greater visibility and to give reviewers a better understanding of more code.

Requesting Review

When requesting review, always request from one of the reviewers listed below and then, *after* (and only after) receiving review+ from them, request super-review from one of the super-reviewers.

"Super" Reviews

There are four people who can give super-reviews in Camino, they are the four project leads: Mike Pinkerton, Simon Fraser, Mark Mentovai, and Josh Aas. A super-reviewer can review a patch in any part of Camino.

Reviewers and Owners

Camino doesn't have traditional "module owners" as the Mozilla project does. However, below is a list of areas in Camino and reviewers/super-reviewers who are comfortable in those areas.

• Adblocking: smokey, smfr
• Bookmarks: smorgan
• Build Config: mento
• Downloading: kreeger
• History: smfr, smorgan
• HTML Form Controls: smfr, smokey (forms.css changes), cflawson (forms.css changes)
• Location Bar & Autocomplete:
• Page Layout:
• Plugins: smfr
• Tabbed Browsing:
• Translations: ludo

In addition, initial reviews can be requested from hwaara and Wevah.

Checking In

After a patch has review+ and superreview+, it needs to be checked in. Check-ins in the Camino project can be made by any of the super-reviewers listed above as well as hwaara.

Also note that the mozilla/camino directory is open for approved Camino check-ins regardless of the state of various trees and branches.