Status Meetings:2008-07-23:Log
Jump to navigation
Jump to search
[12:00pm] You were promoted to operator by chanserv. [12:00pm] delliott was promoted to operator by you. [12:00pm] mento joined the chat room. [12:00pm] mento was promoted to operator by chanserv. [12:01pm] ardissone: wonders how the traffic is today in the valley ;) [12:03pm] murph joined the chat room. [12:03pm] murph was promoted to operator by you. [12:07pm] ardissone: wonders where everyone is :( [12:20pm] peeja joined the chat room. [12:20pm] peeja was promoted to operator by you. [12:21pm] murph left the chat room. (Quit: murph) [12:21pm] ardissone: mento: are you still here, or have you headed off for lunch while we waited? [12:21pm] murph joined the chat room. [12:21pm] murph was promoted to operator by you. [12:23pm] mento: ardissone: [12:23pm] mento: but i'm leaving for lunch in a moment [12:23pm] ardissone: ok [12:23pm] ardissone: let's talk 1.6.2 this afternoon with smorgan? [12:23pm] ardissone: since our current build is 1 gecko behind... [12:25pm] ardissone: and since this meeting is otherwise unable to do anything useful, does anyone else have any progress or anything they'd like to report? [12:25pm] ardissone: peeja, murph, delliott ? [12:26pm] murph: I've been working on the code to add test pages to the url-classifier db... [12:26pm] murph: I'm kind of stuck with the browser window's key view loop again, It's fully working with the exception of reverse tabbing [12:26pm] ardissone: that's certainly a lot of progress! [12:27pm] ardissone: and probably worth considering taking [12:27pm] murph: some kind of hack will eventually be the only likely solution to fix reverse tabbing, as the problem is how AppKit determines insert the toolbar [12:27pm] murph: so, reverse tabbing does work, it just skips the toolbar [12:27pm] ardissone: heh [12:28pm] murph: but the toolbar is in fact integrated into the forward loop [12:28pm] murph: at the correct spot, too [12:28pm] peeja: weird [12:28pm] ardissone: a fully working forward loop is a massive improvement over what we have now [12:28pm] ardissone: peeja: ? [12:28pm] peeja: weird that it only works one way [12:29pm] ardissone: ah [12:29pm] murph: yeah, if there's any focusable view outside the key view loop, it confuses the heck out of AppKit and it messes up -previousKeyView [12:29pm] ardissone: how does a focusable view end up outside of the key view loop? [12:30pm] murph: it's the Gecko ChildVIews... [12:30pm] ardissone: "yay" [12:30pm] murph: you can download a test app I made to demo the problem: https://bugzilla.mozilla.org/attachment.cgi?id=280677 [12:30pm] murph: forward tabbing works, but try reversing :/ [12:31pm] murph: I even used a DTS incident and talked with Apple about this, since I'm trying to wrestle with "magic" AppKit Behavior... [12:31pm] ardissone: 8O [12:32pm] murph: and they said that when loading is complete, to recursively loop over the CHBrowserView ChildView subviews and add them into the loop [12:32pm] murph: but the problem there is that ChildViews can be created even after the initial page load [12:32pm] ardissone: "yay" [12:33pm] ardissone: does gecko give us any way of knowing when we have new CVs? [12:33pm] murph: not that I could tell... [12:33pm] ardissone: awesome :P [12:33pm] murph: ideally we'd just override -didAddSubview, but they're not all directly descendant from CHBrowserView [12:34pm] murph: I also though, since we're on Tiger now, that -autorecauculatesKeyViewLoop would take care of the situation for us, [12:34pm] murph: but that seems broken in our care and breaks the entire loop [12:34pm] murph: s/care/case [12:35pm] ardissone: :P [12:37pm] ardissone: any other exciting tidbits? [12:37pm] murph: so do you think it's reasonable to submit what I have so far, to at least get forward tabbing in a working state? [12:37pm] ardissone: i think so, yes [12:38pm] ardissone: it's a persistent annoyance even to people like me who don't use FKA much, so just going forward should help a huge amount [12:38pm] ardissone: s/much/or tabbing much/ [12:39pm] ardissone: the problem will of course be getting reviewers, but we might be able to convince mento he wants to review it ;) [12:40pm] murph: ok, I'll ready it up then :) [12:40pm] kreeger joined the chat room. [12:40pm] kreeger was promoted to operator by you. [12:40pm] ardissone: great [12:40pm] ardissone: ! [12:40pm] ardissone: anything else from you? [12:42pm] murph: nope, that's about it :) [12:43pm] ardissone: k [12:43pm] ardissone: i landed the toolkit patch mon night, so we're good to go from a core/build perspective on safebrowsing [12:44pm] ardissone: peeja, delliott, kreeger: any of you have anything? [12:46pm] kreeger: nein [12:47pm] ardissone: ok then [12:47pm] ardissone: everyone have a good week [12:47pm] kreeger left the chat room. [12:47pm] ardissone: work on some bugs or reviews [12:47pm] ardissone: and we'll see you next week [12:47pm] ardissone: (hopefully) [12:48pm] ardissone: ;)